Remove custom page template support #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheIsotopes
suggested changes
Oct 27, 2021
Comment on lines
+15
to
+19
| if apiVersion >= 1.042 then | ||
| vtx_tables = assert(loadScript("/BF/VTX/"..mcuId..".lua"))() | ||
| else | ||
| vtx_tables = assert(loadScript("/BF/VTX/vtx_defaults.lua"))() | ||
| end |
There was a problem hiding this comment.
should be
if apiVersion >= 1.042 then
vtx_tables = assert(loadScript("/SCRIPTS/BF/VTX_TABLES/"..mcuId..".lua"))()
else
vtx_tables = assert(loadScript("/SCRIPTS/BF/VTX_TABLES/vtx_defaults.lua"))()
end
Member
Author
There was a problem hiding this comment.
As long as #401 isn't merged, the vtx tables will still be in /BF/VTX
mikeller
approved these changes
Oct 31, 2021
Member
|
Nice cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes support for custom page templates. We're not using it and we don't need it.
The idea was to be able to have custom layouts for pages/screen resolutions, but so far we have been doing just fine with the default templates.